On Thu, 12 Mar 2026 15:43:47 GMT, Roman Kennke <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 65 commits: >> >> - Merge branch 'master' into JDK-8363996-Obsolete-UseCompressedClassPointers >> - Replace Metaspace::using_class_space with define >> - Update src/hotspot/cpu/x86/macroAssembler_x86.hpp >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Replace Klass::_metadata union with narrowKlass member >> - Ivan: fix various instances of ObjLayout::undefined should assert >> - Ivan: Update src/hotspot/share/oops/instanceKlass.cpp >> >> Co-authored-by: Ivan Walulya <[email protected]> >> - David: reduce diff in ObjectCountEventVerifier.java >> - David: minimize change in GetObjectSizeIntrinsicsTest.java >> - David: minimize diffs in TestZGCWithCDS.java >> - David: minimize diffs for >> runtime/ErrorHandling/TestVMConfigInHsErrFile.java >> - ... and 55 more: https://git.openjdk.org/jdk/compare/9a26b4af...be3a902b > > src/hotspot/share/services/memoryService.cpp line 122: > >> 120: _pools_list->append(_metaspace_pool); >> 121: >> 122: _compressed_class_pool = new CompressedKlassSpacePool(); > > Does this make sense on 32 bit? Or should it be guarded with > INCLUDE_CLASS_SPACE instead? You are probably right. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2958280359
