On Thu, 12 Mar 2026 15:42:55 GMT, Roman Kennke <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 65 commits: >> >> - Merge branch 'master' into JDK-8363996-Obsolete-UseCompressedClassPointers >> - Replace Metaspace::using_class_space with define >> - Update src/hotspot/cpu/x86/macroAssembler_x86.hpp >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Replace Klass::_metadata union with narrowKlass member >> - Ivan: fix various instances of ObjLayout::undefined should assert >> - Ivan: Update src/hotspot/share/oops/instanceKlass.cpp >> >> Co-authored-by: Ivan Walulya <[email protected]> >> - David: reduce diff in ObjectCountEventVerifier.java >> - David: minimize change in GetObjectSizeIntrinsicsTest.java >> - David: minimize diffs in TestZGCWithCDS.java >> - David: minimize diffs for >> runtime/ErrorHandling/TestVMConfigInHsErrFile.java >> - ... and 55 more: https://git.openjdk.org/jdk/compare/9a26b4af...be3a902b > > src/hotspot/share/gc/shared/gcTrace.cpp line 126: > >> 124: send_meta_space_summary_event(when, summary); >> 125: send_metaspace_chunk_free_list_summary(when, Metaspace::NonClassType, >> summary.metaspace_chunk_free_list_summary()); >> 126: send_metaspace_chunk_free_list_summary(when, Metaspace::ClassType, >> summary.class_chunk_free_list_summary()); > > So this would send the JFR MetaspaceChunkFreeListSummary event, even if we > have no real class-space on 32-bit? Is this useful, or should we guard this > with INCLUDE_CLASS_SPACE instead? Yes, you are right. The numbers would all read zero. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2958271252
