On Fri, 17 Apr 2026 12:44:32 GMT, Thomas Schatzl <[email protected]> wrote:
>> I should have mentioned what this is. This part of the code puts a >> (uintptr_t*) in the first element of _bit_mask if the bit mask is too large >> to fit the static _bit_mask array. It is messing with the type system and we >> should probably rewrite this to use a union instead. > > Sorry for not being clear about this, and I should have removed this comment. > I did look at this after writing the comment and before submitting my review, > and have the same impression that this should be a union or something. This > is really ugly. > Extra CR is totally fine. I've created #30820 to update the code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30786#discussion_r3109550017
