On Wed, 15 Apr 2026 02:02:16 GMT, SendaoYan <[email protected]> wrote:
>> Hi all, >> >> Test jdk/internal/platform/cgroup/TestCgroupMetrics.java report fails when >> the cpuset unmounted. The details shows in jbs issue. I think it's better to >> check the 'cpu period' or 'cpuset' available or not before run the releated >> tests. >> >> Change has been verified locally. Test-fix only, no risk. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > SendaoYan has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 10 additional commits since > the last revision: > > - Merge branch 'openjdk:master' into jbs8374364 > - Merge branch 'openjdk:master' into jbs8374364 > - Merge branch 'openjdk:master' into jbs8374364 > - Merge branch 'openjdk:master' into jbs8374364 > - Update comment "If cgroups is not configured, the test is skipped." which > suggestion from @dholmes-ora > > Co-authored-by: David Holmes > <[email protected]> > - Update copyright year for > test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java > - Check cpu period and cpuset avaialable before test > - Fix year > - Move DockerTestUtils.checkCanTestDocker() inside MetricsTester > - 8374364: TestCgroupMetrics.java fails when docker service unavailable The changes look ok, also verified locally. It seems to miss the root cause of the crash however. I think we should also address that instead of just adding a guard in front of it. See below. test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java line 179: > 177: } > 178: } > 179: return RETVAL_UNAVAILABLE; The log from the JBS issue seems to crash here. I think we should also address this by checking that `stats` is not null before doing `stats.split()`. ------------- PR Review: https://git.openjdk.org/jdk/pull/28996#pullrequestreview-4190250165 PR Review Comment: https://git.openjdk.org/jdk/pull/28996#discussion_r3155373224
