On Tue, 28 Apr 2026 15:37:53 GMT, Casper Norrbin <[email protected]> wrote:
>> SendaoYan has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 10 additional commits >> since the last revision: >> >> - Merge branch 'openjdk:master' into jbs8374364 >> - Merge branch 'openjdk:master' into jbs8374364 >> - Merge branch 'openjdk:master' into jbs8374364 >> - Merge branch 'openjdk:master' into jbs8374364 >> - Update comment "If cgroups is not configured, the test is skipped." which >> suggestion from @dholmes-ora >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Update copyright year for >> test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java >> - Check cpu period and cpuset avaialable before test >> - Fix year >> - Move DockerTestUtils.checkCanTestDocker() inside MetricsTester >> - 8374364: TestCgroupMetrics.java fails when docker service unavailable > > test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java line 179: > >> 177: } >> 178: } >> 179: return RETVAL_UNAVAILABLE; > > The log from the JBS issue seems to crash here. I think we should also > address this by checking that `stats` is not null before doing > `stats.split()`. Thanks. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28996#discussion_r3158477118
