On Wed, 29 Apr 2026 09:15:29 GMT, Casper Norrbin <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check stats before invoke stats.split
>
> test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java line 175:
>
>> 173: if (stats == null) {
>> 174: throw new SkippedException("Failed to get file contents for
>> " + subSystem + " " + metric);
>> 175: }
>
> This should probably return `RETVAL_UNAVAILABLE` like below, instead of
> skipping. This helper shouldn't decide if the whole test is skipped. That way
> behavior is consistent.
Sorry for the mistabke. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28996#discussion_r3159859226
