On Wed, 29 Apr 2026 03:53:51 GMT, SendaoYan <[email protected]> wrote:

>> Hi all,
>> 
>> Test jdk/internal/platform/cgroup/TestCgroupMetrics.java report fails when 
>> the cpuset unmounted. The details shows in jbs issue. I think it's better to 
>> check the 'cpu period' or 'cpuset' available or not before run the releated 
>> tests.
>> 
>> Change has been verified locally. Test-fix only, no risk.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> SendaoYan has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Check stats before invoke stats.split

test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java line 175:

> 173:         if (stats == null) {
> 174:             throw new SkippedException("Failed to get file contents for 
> " + subSystem + " " + metric);
> 175:         }

This should probably return `RETVAL_UNAVAILABLE` like below, instead of 
skipping. This helper shouldn't decide if the whole test is skipped. That way 
behavior is consistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28996#discussion_r3159818241

Reply via email to