On Thu, 30 Apr 2026 00:58:06 GMT, Dean Long <[email protected]> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8380080: Addressed reviewer's comments. > > src/hotspot/share/interpreter/interpreterRuntime.cpp line 1510: > >> 1508: assert(oopDesc::is_oop(member_name_oop), "member_name_oop should be >> an oop"); >> 1509: assert(java_lang_invoke_MemberName::is_instance(member_name_oop) || >> java_lang_invoke_DirectMethodHandle::is_instance(member_name_oop), >> "member_name_oop is not MemberName or DMH"); >> 1510: #endif > > Do you think we should perform any of the above checks in a product build, > and return null if they fail? Yes, that is a good idea to extend it to prod as well, just in case. I changed asserts to guarantees. > test/hotspot/jtreg/compiler/jsr292/patches/java.base/java/lang/invoke/MethodHandleHelper.java > line 56: > >> 54: } >> 55: >> 56: @ForceInline > > I think this method is only used by one test, so it seems better to just fix > that test to use the new arg order and get rid of the wrapper. Okay, I removed the wrapper and changed the order of args in 2 affected tests (including the new one). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30946#discussion_r3167002990 PR Review Comment: https://git.openjdk.org/jdk/pull/30946#discussion_r3167003298
