On Wed, 6 May 2026 22:14:36 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8380080: Addressed reviewer's comments.
>
> src/hotspot/share/interpreter/interpreterRuntime.cpp line 1508:
>
>> 1506: guarantee(member_name_oop != nullptr, "member_name_oop should not be
>> nullptr");
>> 1507: guarantee(oopDesc::is_oop(member_name_oop), "member_name_oop should
>> be an oop");
>> 1508: guarantee(java_lang_invoke_MemberName::is_instance(member_name_oop)
>> || java_lang_invoke_DirectMethodHandle::is_instance(member_name_oop),
>> "member_name_oop is not MemberName or DMH");
>
> Nit: This line is too long. It is better to split it.
Makes sense, fixed.
> test/hotspot/jtreg/runtime/interpreter/PopFrameMethodNameInvariantTest.java
> line 102:
>
>> 100: if (needsBreak) {
>> 101: break;
>> 102: }
>
> Nit: Would it be simpler if a labeled brake is used here like below? :
>
> outerLoop: // Label for the outer loop
> for (int i = 0; i < 5; i++) {
> for (int j = 0; j < 5; j++) {
> if (i == 2 && j == 2) {
> break outerLoop; // Terminates the loop labeled 'outerLoop'
> }
> System.out.println("i: " + i + ", j: " + j);
> }
> }
I think it is the same, but a bit shorter. Addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30946#discussion_r3200212959
PR Review Comment: https://git.openjdk.org/jdk/pull/30946#discussion_r3200215185
