On Thu, 30 Apr 2026 09:43:44 GMT, Anton Artemov <[email protected]> wrote:
>> Hi, please consider the following changes: >> >> this fix adds extra asserts into >> `interpreterRuntime::member_name_arg_or_null()` and slightly changes its >> logic with respect to bad oops. The goal is to detect if the >> `member_name_oop` is not pointing at a member name in fact, which could have >> happened before, when using `MethodHandleHelper.linkToStatic()` with wrong >> order of arguments. A separate test is added. >> >> Tested in tiers 1 - 5. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Anton Artemov has updated the pull request incrementally with one additional > commit since the last revision: > > 8380080: Addressed reviewer's comments. I'm okay with the fix in general. Posted one nit though. test/hotspot/jtreg/runtime/interpreter/PopFrameMethodNameInvariantTest.java line 102: > 100: if (needsBreak) { > 101: break; > 102: } Nit: Would it be simpler if a labeled brake is used here like below? : outerLoop: // Label for the outer loop for (int i = 0; i < 5; i++) { for (int j = 0; j < 5; j++) { if (i == 2 && j == 2) { break outerLoop; // Terminates the loop labeled 'outerLoop' } System.out.println("i: " + i + ", j: " + j); } } ------------- PR Comment: https://git.openjdk.org/jdk/pull/30946#issuecomment-4392849373 PR Review Comment: https://git.openjdk.org/jdk/pull/30946#discussion_r3198030588
