On Fri, 8 May 2026 17:35:34 GMT, Kevin Walls <[email protected]> wrote:
>> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows >> (MacOS is "future work"). >> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs >> the existing native diagnostic command parser and command implementations. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > consistent libdirs, not libdir, as can be a list. Use > jdk.internal.util.OperatingSystem for OS check. src/jdk.attach/share/classes/sun/tools/attach/VirtualMachineCoreDumpImpl.java line 103: > 101: throw new IOException("Not a MiniDump: '" + filename > + "'"); > 102: } > 103: } else if (OperatingSystem.isLinux()) { I think you'll end up doing some refactoring so that this is not shared code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3210358214
