On Wed, 27 May 2026 04:43:07 GMT, Shiv Shah <[email protected]> wrote:

> Converted 44 shell tests to Java drivers using JavaAgentBuilder and test 
> library utilities
>  
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/java/lang/instrument/ManifestTestDriver.java line 277:

> 275:         try {
> 276:             if (Files.isDirectory(path)) {
> 277:                 for (Path child : Files.list(path).toList()) {

Should this use try-with-resources for `Files#list`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3313899630

Reply via email to