On Wed, 3 Jun 2026 11:28:00 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Shiv Shah has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8209814: Fix manifest capabilities and ProblemList alignment per review > > test/jdk/ProblemList.txt line 413: > >> 411: >> 412: java/lang/instrument/RedefineBigClassTest.java >> 8065756 generic-all >> 413: java/lang/instrument/RetransformBigClassDriver.java >> 8065756 generic-all > > Nit: Better to align bug number to the old alignment. fixed, aligned to match nearby entries. > Nit: This one and previous shell > ([AppendToBootstrapClassPathSetUp.sh](https://github.com/openjdk/jdk/pull/31288/changes#diff-73e9584bfe8b61b51c35650555295e76e7080fd4af7c677bb19d4bcb41649fee)) > scripts are using `-g` option for `javac` compilation. I'm not sure it is > really needed though. But I do not see this option was adopted in java-based > build. It can be that I've missed where this option is used. Anyway, just > wanted to double check nothing is missed here. jtreg’s @build includes -g by default, so CompilerUtils.compile() doesn’t need it explicitly. VerifyLocalVariableTableOnRetransformTest (which depends on LVT) passes on all 4 platforms. the only test that explicitly needs -g is RetransformWithMethodParametersTest which already has @run compile -g -parameters. > test/jdk/java/lang/instrument/modules/AppendToClassPathModuleTest.java line > 30: > >> 28: * @library src /test/lib >> 29: * @build test/* >> 30: * @run driver BuildModuleAgent > > Q: The line `@run driver BuildModuleAgent` was added, but `BuildModuleAgent` > was not added to any `@build` line. The test only has the line: `@build > test/*`. The `BuildModuleAgent.java` is not under `src/test/*` and is not > going to be compiled. Is it correct? @run driver auto-compiles from the test source directory. verified, test passes on all 4 platforms including AppendToClassPathModuleTest. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3357824052 PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3357832176 PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3357837866
