On Wed, 27 May 2026 04:43:07 GMT, Shiv Shah <[email protected]> wrote:
> Converted 44 shell tests to Java drivers using JavaAgentBuilder and test > library utilities > > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/ProblemList.txt line 413: > 411: > 412: java/lang/instrument/RedefineBigClassTest.java > 8065756 generic-all > 413: java/lang/instrument/RetransformBigClassDriver.java > 8065756 generic-all Nit: Better to align bug number to the old alignment. test/jdk/java/lang/instrument/AppendToClassPathSetUp.sh line 60: > 58: echo "CLASSPATH=${CLASSPATH}" > 59: > 60: JAVAC="${COMPILEJAVA}/bin/javac -g" Nit: This one and previous shell ([AppendToBootstrapClassPathSetUp.sh](https://github.com/openjdk/jdk/pull/31288/changes#diff-73e9584bfe8b61b51c35650555295e76e7080fd4af7c677bb19d4bcb41649fee)) scripts are using `-g` option for `javac` compilation. I'm not sure it is really needed though. But I do not see this option was adopted in java-based build. It can be that I've missed where this option is used. Anyway, just wanted to double check nothing is missed here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3348067665 PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3348108390
