On Tue, 15 Sep 2026 13:42:25 GMT, Fredrik Bredberg <[email protected]> 
wrote:

>> I'm not opposed to this patch as is, but it's another workaround for a 
>> broken approach to unwinding. 
>> DWARF CFI unwinding is the proper way to do it.
>> https://blog.mozilla.org/jseward/2014/05/13/lul-a-lightweight-unwinder-library-for-profiling-gecko/
>>  is worth investigating.
>
> @theRealAph
> I'm not opposed to fixing this the proper way using DWARF CFI unwinding, but 
> that is a much bigger job. Until that is done, this PR fixes a possible 
> failing `assert()` when trying to profile using `gprofng`.

Hi @fbredber , can you merge master and pull changes from 
https://github.com/offamitkumar/jdk/commit/f15466cbdf8e8f827db87286810ab7866a7fb130,
 I ran testcase on s390 and it seems it is disabled. The architecture is 
mentioned as `s390` instead of `s390x`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32850#issuecomment-5694410341

Reply via email to