On Fri, 18 Sep 2026 15:51:00 GMT, Martin Doerr <[email protected]> wrote:
>> Fredrik Bredberg has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Updated copyright date >> - s390 fix >> - Merge branch 'master' into 8382486_assert_failed_in_frame_sender >> - 8382486: assert failed in frame::sender > > +1 > I believe that the sender frame should always exist because of the other fp > related checks which have been done before (comment "might crash if the frame > has no parent" before `link()`). So, having this additional check looks > reasonable to me. > I had already tested this PR on all our platforms. > @TheRealMDoerr, @RealFYang, @offamitkumar Hi guys! Here is a > profiler/`AsyncGetCallTrace()` related fix that avoids an otherwise failing > `assert()`. Maybe you would like to take it for a spin on your platforms. The > failing `assert()` is missing in s390 because loom support was missing when > the `assert()` was added. I haven't added the `assert()` to s390 cause I > think that should be done separately, but I did add the > profiler/`AsyncGetCallTrace()` fix for s390x for symmetrical reasons. Thanks for the ping. My local hs:tier1-hs:tier3 test on linux-riscv64 using fastdebug is good. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32850#issuecomment-5756910713
