Paul, I just modified the code according your comments. And the new webrev is available, please kindly help check, http://cr.opensolaris.org/~uniopen/mrtg
Thanks. Paul Cunningham wrote: > This mainly looks good to me, below are a few minor comments ... > > Paul > > Lizhong Li wrote: >> >> I am porting the package 'mrtg' to opensolaris, which can monitor >> SNMP network >> devices and draw pretty pictures showing how much traffic has passed >> through >> each interface. >> >> Could you please review it ? >> http://cr.opensolaris.org/~uniopen/mrtg > > === Start of Comments === > > 1. usr/src/cmd/Makefile > & usr/src/pkgdefs/Makefile > These need resyncing with the gate otherwise it looks > as though you are trying to delete stuff > > Also update the copyright year > > 2. usr/src/cmd/mrtg/install-sfw > You could pass in the VERS= info from the Makefile.sfw as > an environment var. > > 3. package dependencies > You are using the default DEPEND file, have you checked you > have no other dependencies with the dependency checker script? > > 4. usr/src/pkgdefs/SUNWmrtg/pkginfo.tmpl > Expand the DESC= line. Plus put version at end in brackets. > > 5. usr/src/pkgdefs/SUNWmrtg/prototype_sparc > Line 47 - the name on the comment line is wrong > > === End of Comments ===== -- Thanks, Lizhong
