Amanda Waite wrote: > The two man pages you've created have interface stability information > in them, which is correct when creating new man pages, but you then > install them with '_install M' which adds the contents of > sunman-stability to them. > > Can you check the man page only has the interface stability specified > once. I believe that if you create your own man pages including > stability information, you should install them as ordinary files. Yes, the two man pages have interface stability information in them, so I'll use '_install N' for them.
The webrev is updated. http://cr.opensolaris.org/~uniopen/mrtg/ Thanks. > > Otherwise it looks fine. > > BTW: The interface stability is different in the man pages to that > specified in the sunman-stability file, which may or may not be a > problem. > > Amanda > > > Lizhong Li wrote: >> Hi all, >> >> I just updated the webrev according your comments, could you kindly help >> me review it ? >> >> http://cr.opensolaris.org/~uniopen/mrtg/ >> >> thanks. >> >> >> Paul Cunningham wrote: >> >>>> Is it enough for an brief manpage if it's necessary to put the command >>>> rateup into /usr/bin/ ? >>>> >>> That's sounds okay to me >>> >>> p >>> >>> Lizhong Li wrote: >>> >>>> Paul and Jim, >>>> >>>> I just found that some customers maybe uses this tool 'rateup' to >>>> generate graphs they want ( see the link below ), so perhaps we >>>> should add a brief manpage for it ? >>>> http://oss.oetiker.ch/mrtg/nable-mrtg.en.html#nabble-td831333%7Ca831333 >>>> >>>> >>>> Or is it applicable to move it to other dirs instead of /usr/bin/ >>>> since just few customers uses this tool ? >>>> >>>> Paul Cunningham wrote: >>>> >>>>>>>>> I can add the manpage for mrtg-traffic-sum, >>>>>>>>> but for rateup, it's just used by mrtg program itself and has >>>>>>>>> no user interfaces, >>>> Sorry for the confusion, it gives the following prompt : >>>> >>>> Usage: ./rateup -f <parameter file> >>>> ./rateup directory basename [sampletime] [t sampletime] >>>> [-(t)ransparent] [-(b)order][u|a|g|h|m in out abs_max] [i/p file >>>> maxvi maxvo maxx maxy growright step bits] >>>> >>>> and the description in rateup.c is: >>>> >>>> MRTG 2.16.2 -- Rateup >>>> ********************* >>>> >>>> Rateup is a fast add-on to the great MRTG Traffic monitor. It >>>> makes >>>> the database file updates much faster, and creates the graphic >>>> image >>>> files, ready for processing by PPMTOGIF. It also reduces memory >>>> requirements by a factor of 10, and increases the speed of updates >>>> by a factor of at least 10. This makes it feasible to run mrtg >>>> every 5 minutes. >>>> >>>> rateup attempts to compensate for missed updates by repeating >>>> the last >>>> sample, and also tries to catch bad update times. The .log >>>> file stores >>>> real history every five minutes for 31 hours, then 'compresses' >>>> the >>>> history into 30 minute samples for a week, then 2-hour samples for >>>> 31 days, then daily samples for two years. This ensures that the >>>> log files don't grow in size. >>>> >>>> The log files are a slightly different format, but convert.perl >>>> will fix that for you. >>>> >>>> Enjoy! >>>> Dave Rand >>>> dlr at bungi.com >>>> >>>> Is it enough for an brief manpage if it's necessary to put the >>>> command rrateup into /usr/bin/ ? >>>> >>>>>>>>> also there are no such details from the source code and >>>>>>>>> website, should the manpage be added for it ? >>>>>>>>> >>>>>>>>> >>>>>>>> It sounds like rateup is a project private interface, so >>>>>>>> no man page is needed. >>>>>>>> >>>>>>> Just a thought - if it's a private interface should it be in >>>>>>> /usr/bin (ie. picked up by the default PATH)? >>>>>>> >>>>>> It would be nice if it didn't have to be. >>>>>> >>>>>> Lizhong, >>>>>> >>>>>> Is there anyway to configure where rateup is located? >>>>>> >>>>> or less cleanly, you might be able to patch it >>>>> >>>>> paul >>>>> >>>>> >> >> > -- Thanks, Lizhong
