Lizhong Li wrote: > Could you please review it ? > > http://cr.opensolaris.org/~uniopen/mrtg >
Please make the CDDL and copyright headers in all files be consistent with what you have here: http://cr.opensolaris.org/~uniopen/mrtg/usr/src/pkgdefs/SUNWmrtg/pkginfo.tmpl.html usr/src/cmd/mrtg/install-sfw - this code can be reduced using a for loop 46 _install S ${PKGDIR}/bin/mrtg ${BINDIR}/mrtg 555 47 _install S ${PKGDIR}/bin/cfgmaker ${BINDIR}/cfgmaker 555 48 _install S ${PKGDIR}/bin/indexmaker ${BINDIR}/indexmaker 555 49 _install S ${PKGDIR}/bin/mrtg-traffic-sum ${BINDIR}/mrtg-traffic-sum 555 usr/src/pkgdefs/SUNWmrtg/Makefile - this should be removed since you are not using the default depend file. 30 DATAFILES= depend usr/src/pkgdefs/SUNWmrtg/copyright - please update this section. It looks like a straight copy of the gnu-gperf copyright statements 9 ---------------------------------------------------------------- 10 11 Copyright (C) 1989-1998, 2000, 2002-2007 Free Software Foundation, Inc. 12 Written by Douglas C. Schmidt <schmidt at ics.uci.edu> 13 and Bruno Haible <bruno at clisp.org>. 14 15 GNU GPERF is free software; you can redistribute it and/or modify 16 it under the terms of the GNU General Public License as published by 17 the Free Software Foundation; either version 2, or (at your option) 18 any later version. 19 20 GNU GPERF is distributed in the hope that it will be useful, 21 but WITHOUT ANY WARRANTY; without even the implied warranty of 22 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 23 GNU General Public License for more details. 24 25 ---------------------------------------------------------------- 26 usr/src/pkgdefs/SUNWmrtg/prototype_com - do the man pages cover these commands: 52 f none usr/bin/mrtg-traffic-sum 555 root bin 55 f none usr/bin/rateup 555 root bin Cheers, Jim
