I'll review this again once you've addressed Jim's comments.
Amanda Lizhong Li wrote: > Amanda, > > I just modified the code according your comments. > And the new webrev is available, please kindly help check, > http://cr.opensolaris.org/~uniopen/mrtg > > Thanks. > > Amanda waite wrote: > >> 1. usr/src/cmd/Makefile >> Your changes would remove gvim and rdiff-backup. Do a bringover >> update on you workspace, merge the changes and then regenerate your >> webrev and repost it for us. >> >> 2. usr/src/pkgdefs/SUNWmrtg/pkginfo.tmpl >> The Description field should contain a description of the package. >> The Version number is normally included at the end of the field in >> parentheses. >> >> 3. usr/src/pkgdefs/Makefile >> Again, this would remove several packages, update your workspace >> before generating the Webrev >> >> 4. usr/src/pkgdefs/SUNWmrtg/prototype_sparc >> I guess you used SUNWtop as a template as this file still says >> SUNWtop and not SUNWmrtg >> * >> *Amanda* >> >> >> *Lizhong Li wrote: >> >>> Hi All, >>> >>> I am porting the package 'mrtg' to opensolaris, which can monitor >>> SNMP network >>> devices and draw pretty pictures showing how much traffic has passed >>> through >>> each interface. >>> >>> Could you please review it ? >>> >>> http://cr.opensolaris.org/~uniopen/mrtg >>> >>> _______________________________________________ >>> sfwnv-discuss mailing list >>> sfwnv-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >>> >>> > >
