Nico, See comments below ...
Paul Nicolas Williams wrote: > Please review: > > http://cr.opensolaris.org/~nico/sqlite3-3.6.7/webrev/ > > That webrev contains fixes for: > > 6793406 update SQLite3 to 3.6.7 or 3.6.8 > 6793402 Tcl package require sqlite3 is broken > > SQLite3 3.6.7 passes all its "gmake fulltest" tests on x64 and SPARC, > 32- and 64-bit. Version 3.6.8 has been superceded by 3.6.10. I believe > that 3.6.10 is fine, but it does have some as yet unexplained crashes on > 64-bit platforms, which I suspect are problems in the test code, rather > than problems in the library itself, but I can't prove it yet. For now > I will stick with 3.6.7. > > NOTE: Firefox on Solaris will be updated to use SFWNV's libsqlite3 when > this update is delivered. > === Start of Comments === 1. METADATA file Should you have changed stuff in this. If there isn't a METADATA file then add one .... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 2. usr/src/lib/sqlite3/Makefile.sfw You could extract much of the the following ... 46 SQLITE_MAJVER=3 47 SQLITE_MINVER=6 48 SQLITE_MICROVER=7 49 VER=sqlite-$(SQLITE_MAJVER).$(SQLITE_MINVER).$(SQLITE_MICROVER) 50 VER64=$(VER)-64 51 SQLITE3DOCS=sqlite_docs_$(SQLITE_MAJVER)_$(SQLITE_MINVER)_$(SQLITE_MICROVER).zip from the METADATA file, see recent sfwnv integrations for examples. Change 'env ' to 'env - ' throughout Does it really need the following line ... 241 @find . -name core -exec rm -f {} \; if so why? If not delete it. Could you have used the default (Makefile.master) settings of CONFIGURE_OPTIONS=(101) and then added the extra bits to it, eg ... CONFIGURE_OPTIONS += --enable-threadsafe CONFIGURE_OPTIONS += --enable-cross-thread-connections CONFIGURE_OPTIONS += --enable-shared --disable-static CONFIGURE_OPTIONS += --with-tcl="$(ROOTLIB)" etc 3. ever thing else looks okay to me (including the file write permissions :-) ) === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
