On Tue, Jan 27, 2009 at 10:03:59AM +0000, Paul Cunningham wrote:
> 1. METADATA file
> Should you have changed stuff in this. If there isn't a
> METADATA file then add one ....
> http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines
You say this as though I should have known. When I integrated SQLite3 I
went through full c-team review and this never came up. I gather these
are new procedures. Much of this METADATA file's contents is repeated on
every RTI, so if it makes it easier for me to track that, great, and if
some day the RTI process gets simpler, even better.
> 2. usr/src/lib/sqlite3/Makefile.sfw
> You could extract much of the the following ...
> 46 SQLITE_MAJVER=3
> 47 SQLITE_MINVER=6
> 48 SQLITE_MICROVER=7
> 49 VER=sqlite-$(SQLITE_MAJVER).$(SQLITE_MINVER).$(SQLITE_MICROVER)
> 50 VER64=$(VER)-64
> 51
> SQLITE3DOCS=sqlite_docs_$(SQLITE_MAJVER)_$(SQLITE_MINVER)_$(SQLITE_MICROVER).zip
> from the METADATA file, see recent sfwnv integrations for
> examples.
I'm not sure that this is a good idea. I'll look into it, or perhaps do
it in a subsequent putback.
> Change 'env ' to 'env - ' throughout
That will require additional testing -- I've no idea what else in the
environment might be depended on. Please file a separate CR for this.
> Does it really need the following line ...
> 241 @find . -name core -exec rm -f {} \;
> if so why? If not delete it.
I copied it from another makefile. I'll leave it in.
> Could you have used the default (Makefile.master) settings
> of CONFIGURE_OPTIONS=(101) and then added the extra bits
> to it, eg ...
> CONFIGURE_OPTIONS += --enable-threadsafe
> CONFIGURE_OPTIONS += --enable-cross-thread-connections
> CONFIGURE_OPTIONS += --enable-shared --disable-static
> CONFIGURE_OPTIONS += --with-tcl="$(ROOTLIB)"
> etc
What's the difference?
> 3. ever thing else looks okay to me (including the file write
> permissions :-) )
Thanks.
