On Thu, Jan 29, 2009 at 10:00:11AM -0600, Nicolas Williams wrote: > On Thu, Jan 29, 2009 at 11:36:37AM +0000, Paul Cunningham wrote: > > >>> Change 'env ' to 'env - ' throughout > > >>That will require additional testing -- I've no idea what else in the > > >>environment might be depended on. Please file a separate CR for this. > > > > > >I'll defer this. > > > > but it stops it picking up random env variables and hence potentially > > ending up with a different result ... > > Roland Mainz wrote: > > Alright. I'll have to re-test too, so this will take a while (the tests > take forever).
Done. I've updated the webrev. > > >>> CONFIGURE_OPTIONS += --enable-threadsafe > > >>> CONFIGURE_OPTIONS += --enable-cross-thread-connections > > >>> CONFIGURE_OPTIONS += --enable-shared --disable-static > > >>> CONFIGURE_OPTIONS += --with-tcl="$(ROOTLIB)" > > >>> etc > > >>What's the difference? > > >And this. Done too. > > 3. usr/src/lib/sqlite3/Makefile.sfw > > Maybe ... > > If you change your METADATA file ... > > PROGRAM: SQLite3 > > to > > PROGRAM: sqlite3 > > you could extract the name on ... > > 45 TOP=$(SRC)/lib/sqlite3 > > 48 VER=sqlite-$(SQLITE_VER) > > from the METADATA to > > I think that's taking it too far :) But I did it anyways (once I found out about NAME).
