Nico,
> Webrev updated:
> http://cr.opensolaris.org/~nico/sqlite3-3.6.7/webrev/
This mainly looks okay to me, but I have a few more comments, see below ...
Paul
Nicolas Williams wrote:
... cut ...
>
>>> Change 'env ' to 'env - ' throughout
>> That will require additional testing -- I've no idea what else in the
>> environment might be depended on. Please file a separate CR for this.
>
> I'll defer this.
but it stops it picking up random env variables and hence potentially
ending up with a different result ...
Roland Mainz wrote:
> please use "env - ..." and not "env ..." in the Makefiles
> to make sure "configure"&&"make" only see the env variables
> they should really get (and not pick-up any random env
> variable)
> Please use either $(SHELL) or /usr/bin/bash for
> "configure" calls (so we know which one is used and
> "configure" doesn't pick one itself)
>>> Does it really need the following line ...
>>> 241 @find . -name core -exec rm -f {} \;
>>> if so why? If not delete it.
>> I copied it from another makefile. I'll leave it in.
>
> And this.
okay, but if it's not needed its just a waste of processor time
>>> Could you have used the default (Makefile.master) settings
>>> of CONFIGURE_OPTIONS=(101) and then added the extra bits
>>> to it, eg ...
>>> CONFIGURE_OPTIONS += --enable-threadsafe
>>> CONFIGURE_OPTIONS += --enable-cross-thread-connections
>>> CONFIGURE_OPTIONS += --enable-shared --disable-static
>>> CONFIGURE_OPTIONS += --with-tcl="$(ROOTLIB)"
>>> etc
>> What's the difference?
> And this.
okay, but it just makes it more standard and uses already predefined stuff
1. usr/src/lib/sqlite3/METADATA
Add the missing fields for ...
NAME:
SRC:
see http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines
2. usr/src/lib/sqlite3/mapfile-libsqlite3
Is version on line below correct ? ...
29 sqlite_3.5.4 {
3. usr/src/lib/sqlite3/Makefile.sfw
Maybe ...
If you change your METADATA file ...
PROGRAM: SQLite3
to
PROGRAM: sqlite3
you could extract the name on ...
45 TOP=$(SRC)/lib/sqlite3
48 VER=sqlite-$(SQLITE_VER)
from the METADATA to
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit
