Comments below, all much the same as others ... Paul
Vivek Titarmare wrote: > I have posted a webrev for package "janino" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816393-janino/ 1. usr/src/pkgdefs/SUNWjanino/Makefile DElete null line ... 31 DATAFILES= 2. usr/src/lib/janino/sunman/janino.3 Does it need the version number on .. 41 /usr/share/lib/java/janino-2.5.10.jar 3. usr/src/pkgdefs/SUNWjanino/depend Format of top-of-file Copyright year 4. usr/src/pkgdefs/SUNWjanino/copyright Delete lines ... 1 Janino - An embedded Java[TM] compiler & 4 All rights reserved. What licence is this (add) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
