Ok, I will delete the NULL line. And also update the depend file for all the packages.
Thanks, ~Vivek R. T. -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Wednesday, April 15, 2009 2:54 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "jarjar" Vivek, This looks mainly okay to me, but see below .. Paul Vivek Titarmare wrote: > I have posted a webrev for package "jarjar*" which I am > porting to OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816373-jarjar/ 1. usr/src/pkgdefs/SUNWjarjar/Makefile Delete null line .. 31 DATAFILES= 2. normal dependency stuff END
