Comments below from my quick skip through ... Paul
Vivek Titarmare wrote: > I have posted a webrev for package "jdom" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816368-jdom/ 1. usr/src/lib/jdom/sunman/jdom.3 Does this need the version number ? ... 41 /usr/share/lib/java/jdom-1.1.jar 2. usr/src/pkgdefs/SUNWjdom/Makefile Delete null line .. 31 DATAFILES= 3. usr/src/pkgdefs/SUNWjdom/copyright Maybe delete line ... 5 $Id: LICENSE.txt,v 1.11 2004/02/06 09:32:57 jhunter Exp $ 4. usr/src/pkgdefs/SUNWjdom/depend Add Java runtime dependency maybe END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
