Comments below from my quick skip through ... Paul
Vivek Titarmare wrote: > I have posted a webrev for package "log4j" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816370-log4j/ 1. usr/src/lib/log4j/METADATA The SRC: link doesn't actually cause the tarball to be downloaded, is there a better link you can put here? 2. usr/src/lib/log4j/sunman/log4j.3 Version on line ? ... 41 /usr/share/lib/java/log4j-1.2.15.jar 3. SUNWlog4j dependency Maybe add dependency on java runtime 4. usr/src/pkgdefs/SUNWlog4j/copyright Name the licence 5. usr/src/pkgdefs/SUNWlog4j/prototype_com Duplicate lines ... 62 d none usr/share/lib/java/javadoc/log4j 0755 root bin 63 d none usr/share/lib/java/javadoc/log4j 0755 root bin END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
