Hi Jim, thank you for feedback. This is what I get for a copy-and-paste job having picked the wrong example to copy from :)
I made the changes you requested, please see updated webrev: http://cr.opensolaris.org/~dmehra/webalizer/ My component builds successfully with these changes (incl. "make install" from webalizer directory), but when I try to build the package, I get this error... I had it before too, and it seems to go away once I complete a nightly build. Is there something I need to fix in my environment? $ pwd /builds/dm155201/ws/usr/src $ make setup ... $ cd pkgdefs/SUNWwebalizer/ $ make install make: Fatal error: Don't know how to make target `../awk_pkginfo' $ ls total 57 3 Makefile 29 copyright 5 pkginfo.tmpl 4 prototype_i386 3 SCCS/ 4 depend 5 prototype_com 4 prototype_sparc $ Also, I'd like to confirm that sunman-stability really needs the CDDL block. There seems to be three integrated projects that have that (tcl, tk, diffstat), the majority do not have a CDDL block in this file, including the example we reference from the guidelines wiki (section 3.4): http://ostest.central.sun.com/wiki/index.php/Package_Delivery_Project#3._Develop_Software Speaking of which, the METADATA file referenced from above section also doesn't look like the one from meld. If meld is the golden standard, please consider changing links from the wiki to point to meld files. It's been hard for me to come up with "consistent" files because different projects were done in slightly different ways and I wouldn't know which to use as my guideline. Thanks, -- daria Jim Walker wrote: > Daria Mehra wrote: >>> Esteemed reviewers, please take a look at my webrev for webalizer >>> (targeting build 104): >>> >>> http://cr.opensolaris.org/~dmehra/webalizer/ >>> > > few things... > > Take a look at this webrev: > http://cr.opensolaris.org/~jwalker/meld/ > > And, update the METADATA and CDDL headers in most > of your files to the correct format. They should > be consistent. > > usr/src/cmd/webalizer/install-sfw > - change to: > 1 #! /usr/bin/ksh93 > - add: > 30 # stop at first error > 31 set -o errexit > - change to: > 37 source ${SRC}/tools/install.subr > > usr/src/cmd/webalizer/sunman-stability > - add CDDL block after line 2 > 20 Availability SUNWgtar\ > - change to SUNWwebalizer > 22 Interface Stability Volatile\ > - change to Uncommitted > > usr/src/pkgdefs/SUNWwebalizer/copyright > - change to: > 1 For the avoidance of doubt, except that if any license choice other > 2 than GPL or LGPL is available it will apply instead, Sun elects to > 3 use only the General Public License version 2 (GPLv2) at this time > 4 for any software where a choice of GPL license versions is made > 5 available with the language indicating that GPLv2 or any later > 6 version may be used, or where a choice of which version of the GPL > 7 is applied is otherwise unspecified. > 8 > 9 -------------------------------------------------------------------- > 10 > 11 Copyright (C) 1997-2008 Bradford L. Barrett > 12 > 13 > 14 GNU GENERAL PUBLIC LICENSE > 15 Version 2, June 1991 > ... > > Cheers, > Jim
