One more update to the webrev. I removed the wcmgr binary from install-sfw and prototype_com, as it's useless. This program only works if webalizer is compiled with DNS support and I am explicitly compiling without. If I leave wcmgr in the package, you can run it, but it will just produce this message:
$ ./wcmgr ********************* NOTICE!! ********************* This version of the Webalizer was not compiled with DNS support. In order to use this program, you must configure the Webalizer at build time with the DNS support enabled (--enable-dns configure option). **************************************************** Now the reason I disabled DNS is that DNS support in webalizer depends on BerkeleyDB, and I was having trouble linking against it on opensolaris. I see the library file /usr/lib/libdb.so.1 but there's no /usr/lib/libdb.so and it's not found by the linker. It appears that SUNWbdb package does not create /usr/lib/libdb.so symlink (although it creates libdb-java.so) and I'm not sure if that's a bug or intentional. I also came across a scary licensing warning in /usr/lib/bdb/NOTICE which made me think it might be best to avoid using BDB in F/OSS projects. Bottom line - webalizer is built without DNS support so I removed the useless wcmgr binary. However the man page describes DNS functionality. Do i need to put a note somewhere explaining that DNS support is not available? Or would it be best to keep wcmgr, and if the user runs it, the output will tell them DNS is not available? Thanks, -- daria Daria Mehra wrote: > Paul, thank you for feedback, please see updated webrev: > http://cr.opensolaris.org/~dmehra/webalizer/ > > The following changes were made: > > 0. Re-uploaded the source tarball to make sure it's the original one > from project download page... I used to have .tar.gz because I must > have messed with it; the right tarball is .tgz. >> >> 1. usr/src/cmd/webalizer/Makefile.sfw >> > Use "env - ..." and not "env ..." in the Makefiles > > Done. > >> You could change all the lines with '...=/usr/...' to >> '...=$(CFGPREFIX)/...', etc., eg. ... >> 35 --with-gd=$(CFGPREFIX)/include/gd2 > > Done. > >> >> You could extract the name and version from the METADATA >> file replacing '29 VER =...', eg. something like .. >> VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) >> TARBALL = $(VER).tar.gz > > Done in Makefile.sfw. I was wondering if the same would work in > install-sfw but didn't have any luck with that. Does this extraction > only work for makefiles? > >> >> >> 2. usr/src/cmd/webalizer/METADATA >> The wiki guideline at >> http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines >> say there should be 'SRC: ....' & 'NAME: ...' lines. > > Added those. Thanks for the pointer to guideline wiki. > >> >> 3. sample.conf >> Is there anything to tell users what to do with the >> sample.conf file? > > Yes it's all in the manpage. The only thing not mentioned in the > manpage is the location of sample.conf but that should be clear from > the package prototype file. > > From webalizer manpage: > > CONFIGURATION FILES > Configuration files are standard ASCII(7) text files that > may be created or edited using any standard editor. > ... > The file sample.conf provided with the distribu- > tion contains lots of useful documentation and examples as > well. > > The manpage also describes where to put the actual configuration file > to be used by webalizer: > > o A default configuration file is scanned for. A file > named webalizer.conf is searched for in the current > directory, and if found, it's configuration data is > parsed. If the file is not present in the current > directory, the file /etc/webalizer.conf is searched > for and, if found, is used instead. > > You can also pass it in via option: > > -c file Use configuration file file. > > Thanks, > -- daria > >
