A few more comments ...
Daria Mehra wrote:
>> 1. usr/src/cmd/webalizer/Makefile.sfw
>>
>> You could extract the name and version from the METADATA
>> file replacing '29 VER =...', eg. something like ..
>> VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
>> TARBALL = $(VER).tar.gz
>
> Done in Makefile.sfw. I was wondering if the same would work in
> install-sfw but didn't have any luck with that. Does this extraction
> only work for makefiles?
You could trying passing it into install-sfw as an option or environment
variable from Makefile.sfw.
Also in Makefile.sfw ...
Delete the line ...
29 #VER = webalizer-2.20-01
Do you need the DESTDIR= on line ..
49 DESTDIR=$(ROOT) $(SHELL) ./install-sfw
I don't think its used in install-sfw
Everything else looks okay to me from my quick skip through.
Paul
Daria Mehra wrote:
> Paul, thank you for feedback, please see updated webrev:
> http://cr.opensolaris.org/~dmehra/webalizer/
>
> The following changes were made:
>
> 0. Re-uploaded the source tarball to make sure it's the original one
> from project download page... I used to have .tar.gz because I must have
> messed with it; the right tarball is .tgz.
>>
>> 1. usr/src/cmd/webalizer/Makefile.sfw
>> > Use "env - ..." and not "env ..." in the Makefiles
>
> Done.
>
>> You could change all the lines with '...=/usr/...' to
>> '...=$(CFGPREFIX)/...', etc., eg. ...
>> 35 --with-gd=$(CFGPREFIX)/include/gd2
>
> Done.
>
>>
>> You could extract the name and version from the METADATA
>> file replacing '29 VER =...', eg. something like ..
>> VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
>> TARBALL = $(VER).tar.gz
>
> Done in Makefile.sfw. I was wondering if the same would work in
> install-sfw but didn't have any luck with that. Does this extraction
> only work for makefiles?
>
>>
>>
>> 2. usr/src/cmd/webalizer/METADATA
>> The wiki guideline at
>> http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines
>> say there should be 'SRC: ....' & 'NAME: ...' lines.
>
> Added those. Thanks for the pointer to guideline wiki.
>
>>
>> 3. sample.conf
>> Is there anything to tell users what to do with the
>> sample.conf file?
>
> Yes it's all in the manpage. The only thing not mentioned in the manpage
> is the location of sample.conf but that should be clear from the package
> prototype file.
>
> From webalizer manpage:
>
> CONFIGURATION FILES
> Configuration files are standard ASCII(7) text files that
> may be created or edited using any standard editor.
> ...
> The file sample.conf provided with the distribu-
> tion contains lots of useful documentation and examples as
> well.
>
> The manpage also describes where to put the actual configuration file to
> be used by webalizer:
>
> o A default configuration file is scanned for. A file
> named webalizer.conf is searched for in the current
> directory, and if found, it's configuration data is
> parsed. If the file is not present in the current
> directory, the file /etc/webalizer.conf is searched
> for and, if found, is used instead.
>
> You can also pass it in via option:
>
> -c file Use configuration file file.
>
> Thanks,
> -- daria
>
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit
