Daria, This mainly looks okay to me, see below for a few comments ...
Paul Daria Mehra wrote: > Hi Jim, thank you for feedback. This is what I get for a copy-and-paste > job having picked the wrong example to copy from :) > > I made the changes you requested, please see updated webrev: > http://cr.opensolaris.org/~dmehra/webalizer/ === Start of Comments === 1. usr/src/cmd/webalizer/Makefile.sfw Apply this ... Roland Mainz wrote: > Use "env - ..." and not "env ..." in the Makefiles to > make sure "configure"&&"make" only see the env variables > they should really get (and not pick-up any random env > variable). You could change all the lines with '...=/usr/...' to '...=$(CFGPREFIX)/...', etc., eg. ... 35 --with-gd=$(CFGPREFIX)/include/gd2 You could extract the name and version from the METADATA file replacing '29 VER =...', eg. something like .. VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) TARBALL = $(VER).tar.gz 2. usr/src/cmd/webalizer/METADATA The wiki guideline at http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines say there should be 'SRC: ....' & 'NAME: ...' lines. 3. sample.conf Is there anything to tell users what to do with the sample.conf file? === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
