It looks good to me Just one minor cosmetic comment, in webalizer/install-sfw you might want to add a comment to say PKGDIR is passed in as an environment variable (just so I don't have to think - where does it get that from??).
paul :-) Daria Mehra wrote: > Last round of review for webalizer (I hope)... > http://cr.opensolaris.org/~dmehra/webalizer/ > > I have patched the man page with the following text, to clarify the > issue of missing binaries due to compiling with "--disable-dns": > > UNSUPPORTED > Note that DNS support is disabled in the OpenSolaris distri- > bution of webalizer. Programs 'wcmgr' and 'webazolver' are > not available as they are only functional if DNS is sup- > ported. > > I know "UNSUPPORTED" is not a standard section in man page layout but I > couldn't think of a more suitable heading, let me know if there's a > better choice. > > Also addressed Paul's comments below. > > Paul Cunningham wrote: >> >> 1. usr/src/cmd/webalizer/Makefile.sfw >> >> >> >> You could extract the name and version from the METADATA >> >> file replacing '29 VER =...', eg. something like .. >> >> VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) >> >> TARBALL = $(VER).tar.gz >> ... >> You could trying passing it into install-sfw as an option or >> environment variable from Makefile.sfw. > > Done. > >> >> Also in Makefile.sfw ... >> >> Delete the line ... >> 29 #VER = webalizer-2.20-01 > > Done. > >> >> Do you need the DESTDIR= on line .. >> 49 DESTDIR=$(ROOT) $(SHELL) ./install-sfw >> I don't think its used in install-sfw > > Right, removed that. > > Thanks, > -- daria -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
