Shawn Walker wrote: > Huie-Ying Lee wrote: >> Hi all, >> >> Please help review code for the pyOpenSSL package which is to be >> integrate to SFWNV consolidation. >> >> PSARC case: 2008/705 >> Bug id: CR6759597 include pyopenssl >> Webrev: http://cr.opensolaris.org/~hylee/pyopenssl/ > > The only question I have is why we would want to package and > distribute the usr/lib/python2.4/vendor-packages/OpenSSL/test > directory and its contents. Those seem like unit tests for the > developers of pyOpenSSL instead of the consumers. > Right. The test directory does contain unit tests. The reasons that they are included are
1. This is the default install behavior. A user that have seen this package from other platforms might expect to see them as well. 2. They can be served as sample examples. 3. It does not hurt to include them, except ~28K bytes of space. I don't mind to remove them, if the consensus here is not to deliver the test files. > I don't feel confident enough to comment on the rest. > Thanks, Huie-Ying
