Huie-Ying, See below comments from my very quick skip through ..
Paul Huie-Ying Lee wrote: > > Please help review code for the pyOpenSSL package which is to be > integrate to SFWNV consolidation. > > PSARC case: 2008/705 > Bug id: CR6759597 include pyopenssl > Webrev: http://cr.opensolaris.org/~hylee/pyopenssl/ === Start of Comments ==== 1. usr/src/lib/pyopenssl/Makefile.sfw Change 'env ' to 'env - ' Combine the two 'clean' 'rm' lines, eg .. clean: -rm -rf $(VER) $(VER64) You could extract the VER= info from the METADATA, see recent sfwnv integrations on how to do that. I don't think you need this ... 68 ($(INSTALL_PROTO) -d $(ROOTPYTHONMODS_DOC); as its created from content of Targetdirs ? 2. usr/src/pkgdefs/SUNWpyopenssl/pkginfo.tmpl You could put the version number at the end of the DESC= line as most people do, eg ... DESC="........... (0.8)" 3. usr/src/pkgdefs/SUNWpyopenssl/prototype_com Do you need the 'write' permission on the files, if not remove it! Just an observation ... 48 d none usr/lib/python2.4/vendor-packages/OpenSSL/64 in /usr/lib, 64 would be a symbolic link to the appropriate arch dir - maybe yours should be to. usr/lib/python2.4/vendor-packages/OpenSSL/test/* Isn't it normal to put 'test' stuff into a separate package if you really need to deliver it (but I may be remember incorrectly). === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
