Huie-Ying Lee wrote: > > I have updated the code to address all the comments that I have > received for the pyOpenSSL package. > The updated webrev is located at the same place, > http://cr.opensolaris.org/~hylee/pyopenssl. > Please take a look and let me know if you have any comments.
Here's a few comments... Please update all the files with the correct CDDL header and copyright header formats. Here's an example: http://cr.opensolaris.org/~jwalker/meld/usr/src/cmd/Makefile.html usr/src/lib/Makefile 85 pyopenssl - unless there are build ordering issues, normally packages are in alphabetical order, after here may be better: 80 pam_pkcs11 \ - also update the CDDL and copyright header to correct format. usr/src/lib/pyopenssl/METADATA - a brief description should be used for the name, maybe something like: pyOpenSSL - Python interface to the OpenSSL library usr/src/lib/pyopenssl/Makefile.sfw - I'm going to think more about this Makefile, but it may be better to use a install-sfw file to do the file transfer work You need to add a man page. usr/src/pkgdefs/SUNWpython-pyopenssl/copyright - I assume you need a disclaimer and copyright section like is included here: http://cr.opensolaris.org/~jwalker/meld/usr/src/pkgdefs/SUNWmeld/copyright.html usr/src/pkgdefs/SUNWpython-pyopenssl/prototype_com 33 NAME="Python language bindings for OpenSSL" 41 DESC="Python language bindings for OpenSSL (0.8)" - is it really just language bindings, or is this name/desc more accurate? "Python interface to the OpenSSL library" usr/src/pkgdefs/SUNWpython-pyopenssl/prototype_i386 - you should use the correct file format like this: http://cr.opensolaris.org/~jwalker/meld/usr/src/pkgdefs/SUNWmeld/prototype_i386.html usr/src/pkgdefs/SUNWpython-pyopenssl/prototype_sparc - you should use the correct file format like this: http://cr.opensolaris.org/~jwalker/meld/usr/src/pkgdefs/SUNWmeld/prototype_sparc.html usr/src/pkgdefs/SUNWpython-pyopenssl/prototype_com - I think this section should be in prototype_i386 48 d none usr/lib/python2.4/vendor-packages/OpenSSL/64 0755 root bin 49 f none usr/lib/python2.4/vendor-packages/OpenSSL/64/SSL.so 0555 root bin 50 f none usr/lib/python2.4/vendor-packages/OpenSSL/64/crypto.so 0555 root bin 51 f none usr/lib/python2.4/vendor-packages/OpenSSL/64/rand.so 0555 root bin Cheers, Jim
