Jim Walker wrote: > Huie-Ying Lee wrote: >> Hello Jim, >> >>> Please update all the files with the correct CDDL header and >>> copyright header formats. Here's an example: >>> http://cr.opensolaris.org/~jwalker/meld/usr/src/cmd/Makefile.html >>> >> I checked all the files, but I couldn't find a file that does not >> have a correct CDDL header and copyright header formats. Could you >> please tell me which file is incorrect ? > > Please take another look. I think you will find > that the headers can be improved. > Fixed, by adding a couple of empty lines and a space is missing before ident. >>> >>> You need to add a man page. >>> >> The reasons that a man page was not added are listed below: >> >> 1. All the vendor packages for Python2.4 are located in the standard >> /usr/lib/python2.4/vendor-packages directory, so it should be of any >> problems for a Python programmer to find this package and its >> corresonding document in >> /usr/lib/python2.4/vendor-packages/OpenSSL/doc. 2. The deliverables >> of this package has been approved by PSARC, without the requirement >> for a man page. 3. There are no man pages supplied by any existing >> Python vendor packages that I could find. > > Please check with the sfw c-team to see if they will give you > a waiver. > Ok. >>> usr/src/pkgdefs/SUNWpython-pyopenssl/copyright - I assume you need >>> a disclaimer and copyright section like is included here: >>> http://cr.opensolaris.org/~jwalker/meld/usr/src/pkgdefs/SUNWmeld/copyright.html >>> >>> >>> >> The copyright file in the usr/src/pkgdefs/SUNWpython-pyopenssl >> directory is copied directly from the original pyOpenSSL tarball. >> I don't think I should alter it. > > Sorry there is no exception. This statement in section 3 of the > the copyright file is the reason the disclaimer is needed. You > should also add the copyright statements. > > "(If a newer version than version 2 of the ordinary GNU General > Public License has appeared, then you can specify that version > instead if you wish.)" > Ok, the copyright file is updated.
The webrev is updated at http://cr.opensolaris.org/~hylee/pyopenssl. Thanks, Huie-Ying
