John Cui wrote: > Hi all, > I am porting pstree, which is a CLI tool to show the ps listing as a > tree. Please have a look, any comment is valuable. > > Webrev: http://cr.opensolaris.org/~johncui/pstree/ >
usr/src/cmd/pstree/METADATA - change GPL to GPLv2, version is important :) usr/src/cmd/patchutils/Makefile.sfw usr/src/cmd/patchutils/install-sfw - remove the two spaces (ie. "# " should be "# ") in CDDL header. usr/src/cmd/patchutils/Makefile.sfw I think this: 45 $(VER)/$(PROG).c: $(TARBALL) 46 $(MKDIR) -p $(VER) 47 ( cd $(VER); gtar zxf ../$(TARBALL); \ 48 touch $(PROG).c ) Can be: 45 $(VER)/$(PROG).c: $(TARBALL) 46 /usr/sfw/bin/gtar xpfz $(TARBALL) 47 touch $(VER)/$(PROG).c usr/src/cmd/pstree/pstree.1 - need to add stability block like this: 153 .SH ATTRIBUTES 154 See 155 .BR attributes (5) 156 for descriptions of the following attributes: 157 .sp 158 .TS 159 box; 160 cbp-1 | cbp-1 161 l | l . 162 ATTRIBUTE TYPE ATTRIBUTE VALUE 163 = 164 Availability SUNWpstree 165 = 166 Interface Stability Uncommitted 167 .TE 168 .PP usr/src/pkgdefs/SUNWpstree/Makefile - since you don't have additional dependencies you can do this in your Makefile and remove depend file include ../Makefile.com DATAFILES= depend .KEEP_STATE: Good job! Cheers, Jim
