John, Here are some comments from my quick skip through (some of them may duplicate Jim's), see below ...
Paul John Cui wrote: > > I am porting pstree, which is a CLI tool to show the ps listing as a > tree. Please have a look, any comment is valuable. > > Webrev: http://cr.opensolaris.org/~johncui/pstree/ === Start of Comments ==== 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile put in alphabetical order. 2. usr/src/cmd/pstree/Makefile.sfw Change ... 46 $(MKDIR) -p $(VER) 47 ( cd $(VER); gtar zxf ../$(TARBALL); \ maybe, to something like gzip -dc $(TARBALL) | $(GTAR) xpf --no-same-owner - 3. usr/src/cmd/pstree/install-sfw You could pass the PKGVERS= info into the script from Makefile.sfw using an environment variable. 4. usr/src/cmd/pstree/pstree.1 Don't you need to add the sun stability stuff to these man page, either directly in the file or using the sunman-stability modification via '_install M ...' in your install-sfw script. 5. usr/src/pkgdefs/SUNWpstree/depend This looks like the default 'depend' file. Have you checked you have no other dependencies (using dependency checker script); if you have no other them remove this file and add 'DATAFILES = depend' into your SUNWpstree/Makefile === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
