Hi Jim and Paul, I have updated the changes, please have a look at my reply inline below,
webrev still http://cr.opensolaris.org/~johncui/pstree/ Jim Walker wrote on 11/26/08 14:28: > usr/src/cmd/pstree/METADATA > - change GPL to GPLv2, version is important :) Done. > usr/src/cmd/patchutils/Makefile.sfw > usr/src/cmd/patchutils/install-sfw > - remove the two spaces (ie. "# " should be "# ") in CDDL header. Done. > === Start of Comments ==== > > 1. usr/src/cmd/Makefile > & usr/src/pkgdefs/Makefile > put in alphabetical order. Done. > usr/src/cmd/patchutils/Makefile.sfw > I think this: > 45 $(VER)/$(PROG).c: $(TARBALL) > 46 $(MKDIR) -p $(VER) > 47 ( cd $(VER); gtar zxf ../$(TARBALL); \ > 48 touch $(PROG).c ) > Can be: > 45 $(VER)/$(PROG).c: $(TARBALL) > 46 /usr/sfw/bin/gtar xpfz $(TARBALL) > 47 touch $(VER)/$(PROG).c > > 2. usr/src/cmd/pstree/Makefile.sfw > Change ... > 46 $(MKDIR) -p $(VER) > 47 ( cd $(VER); gtar zxf ../$(TARBALL); \ > maybe, to something like > gzip -dc $(TARBALL) | $(GTAR) xpf --no-same-owner - The updated version is: 45 $(VER)/$(PROG).c: $(TARBALL) 46 $(MKDIR) -p $(VER) 47 ( cd $(VER); \ 48 gzip -dc ../$(TARBALL) | $(GTAR) xpf - --no-same-owner; \ 49 touch $(PROG).c ) I have to keep MKDIR -p since the original TARBALL does not contains any directory structure, the files will be extract the current dir. Paul, One question for gzip | $(GTAR), I do find it is used in quantity, why do not we use $(GTAR) directly? > 3. usr/src/cmd/pstree/install-sfw > You could pass the PKGVERS= info into the script from > Makefile.sfw using an environment variable. Done. > usr/src/cmd/pstree/pstree.1 > - need to add stability block like this: > 153 .SH ATTRIBUTES > 154 See > 155 .BR attributes (5) > 156 for descriptions of the following attributes: > 157 .sp > 158 .TS > 159 box; > 160 cbp-1 | cbp-1 > 161 l | l . > 162 ATTRIBUTE TYPE ATTRIBUTE VALUE > 163 = > 164 Availability SUNWpstree > 165 = > 166 Interface Stability Uncommitted > 167 .TE > 168 .PP Done. > 4. usr/src/cmd/pstree/pstree.1 > Don't you need to add the sun stability stuff to these > man page, either directly in the file or using the > sunman-stability modification via '_install M ...' in your > install-sfw script. Paul, I am not sure whether I catch your point. It seems that there are two things: 1. I do not need to add the sun stability stuff to the man page. It seems Jim and you have different opinions. Could you tell me where I can find the standard? 2. Do not need sunman-stability, and _install M in install-sfw There are no such stuff for my porting. > usr/src/pkgdefs/SUNWpstree/Makefile > - since you don't have additional dependencies you can > do this in your Makefile and remove depend file > > include ../Makefile.com > > DATAFILES= depend > > .KEEP_STATE: Done. > 5. usr/src/pkgdefs/SUNWpstree/depend > This looks like the default 'depend' file. Have you > checked you have no other dependencies (using dependency > checker script); Yes, there are no other dependencies for this package. And please pay attention to usr/src/pkgdefs/SUNWpstree/prototype_com: 39 # packaging files 40 i pkginfo 41 i copyright there is no such line "i depend". Thanks, -- John Cui x82195 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20081126/00433752/attachment.html>
