Milan Jurik wrote on 11/28/08 19:22: > Hi John, > > John Cui p??e v ?t 27. 11. 2008 v 11:42 +0800: > >> Alan Coopersmith wrote on 11/27/08 00:17: >> >>> John Cui wrote: >>> >>> >>>> Hi all, >>>> I am porting pstree, which is a CLI tool to show the ps listing as a >>>> tree. Please have a look, any comment is valuable. >>>> >>>> >>> Not really code review, but something you'll be asked at ARC - what's >>> the difference between this and the existing Solaris ptree? They seem >>> to be very very similar, except that ptree knows about Solaris features >>> such as zones, contracts, etc. If there is a reason for a separate >>> pstree, will you be adding similar support to it? Would it make more >>> sense to add any missing pstree features to the existing ptree and then >>> make a pstree->ptree symlink? >>> >> Yes, they are very similar. The difference is, besides you mentioned >> ptree unique features, pstree provides more options/features. One reason >> to port pstree is its popular, both blastwave and sunfreeware provide >> binary, and got 14 in http://muskoka.sfbay/~sch/pkg/search.html >> >> Certainly if Sun thinks it is worth adding the missing features to ptree >> and put it on the schedule, a pstree->ptree link is enough. >> > You can do it, not only "Sun". Maybe it will cost you less in future in > comparison to maintaining pstree. > > Also, does users really need those options? Or are they missing only > "pstree" command? E.g. it's usual that "ps" has different set of params > on different platforms Frankly, I had not thought it so much when porting this package. And I have no idea about what options the users really need. I saw there were top, gtar, p7zip, ... Maybe all of these apply to them as well. ;-)
I will discuss it with Jim. Thanks, -- John Cui x82195
