Paul Cunningham wrote: > Huie-Ying Lee wrote: > ... cut ... >> >> The webrev is updated at http://cr.opensolaris.org/~hylee/pyopenssl. > > This looks okay to me. > > Just one minor-cosmetic comment .... > > in usr/src/lib/pyopenssl/Makefile.sfw you could move the install bits > (lines 64 to 86) out into a separate 'install-sfw' just so these don't > clutter up the Makefile.sfw file > OK, I have moved out the install bits into a separate "install-sfw" file. The webrev is updated accordingly, please see http://cr.opensolaris.org/~hylee/pyopenssl. > And does this pkg need a man page created for it? > > This issue was raised before. The reasons that a man page was not added are because:
1) All the vendor packages for Python2.4 are located in the standard /usr/lib/python2.4/vendor-packages directory, so it shouldn't be of any problems for a Python programmer to find this package and its corresonding document in /usr/lib/python2.4/vendor-packages/OpenSSL/doc. 2) The deliverables of this package has been approved by PSARC, without the requirement for a man page. 3) There are no man pages supplied by any existing Python vendor packages that I could find. Look like a man page is desirable. I plan to file a man page RFE and work with a man page writer for it. Thanks, Huie-Ying
