Pradhap, See below for my quick skip through comments ...
Paul Pradhap Devarajan wrote: > Hi all, > > Please review the code for librsync integration into SFW consolidation > > webrev is located at: > http://cr.opensolaris.org/~pd155743/librsync/ === Start of Comments ============= 1. usr/src/lib/librsync/Makefile.sfw You might want to use the predefined values for '-prefix=' in Makefile.master, see example in http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html 2. usr/src/pkgdefs/Makefile Put in alphabetical order 3. usr/src/pkgdefs/SUNWlibrsync/depend You might want to move the 'Copyright' statement lines to after the "CDDL HEADER END". Is the sccs ident line correct? Are these dependency pkgs correct? 4. usr/src/pkgdefs/SUNWlibrsync/prototype_i386 Copyright year is wrong === End of Comments =============== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
