Keith M Wesolowski wrote:
> On Mon, Apr 28, 2008 at 11:01:37PM +0200, Roland Mainz wrote:
> 
>> Please add...
>> -- snip --
>> CFLAGS   += -xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1 -xstrconst
>> CFLAGS64 += -xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1 -xstrconst
> 
> I think you mean
> 
> CFLAGS += $(XPG6_MODE) $(XSTRCONST)
> CFLAGS64 += $(XPG6_MODE) $(XSTRCONST)
> 
> Adding naked compiler options means more work for the gatekeepers when
> compiler versions change.

That's especially relevant for -xstrconst, since that option is changing in
future compiler releases to an on/off toggle in the release that turns
read-only strings on by default and to be consistent with the CC option.

I think -xstrconst should last through another compiler release, but not having
to do a global search/replace when it's time to move to Studio 14 would be good.
(It would also make it easier to build with other compilers as well, without
 having to global replace Sun Studio options with gcc ones.)

-- 
        -Alan Coopersmith-           alan.coopersmith at sun.com
         Sun Microsystems, Inc. - X Window System Engineering


Reply via email to