Pradhap Devarajan wrote: > Hi Paul, > Thanks for pointing it out. I have updated the dependency list. Here > is the updated webrev http://cr.opensolaris.org/~pd155743/librsync/ . > Please let me know your comments.
looks okay to me paul > Paul Cunningham wrote: >> >> Pradhap Devarajan wrote: >> >> >>> I have modified scripts to use ksh93 and updated Makefile.sfw based >>> on comments. >>> Update webrev is located at >>> http://cr.opensolaris.org/~pd155743/librsync/ >>> >> >> >> This, usr/src/pkgdefs/SUNWlibrsync/depend, still looks like the >> default 'depend' to me; is it? If it is, remove and add appropriate >> line to SUNWlibrsync/Makefile >> >> Paul >> >> >> >>> Paul Cunningham wrote: >>> >>> >>> >>>> Pradhap, >>>> >>>> Pradhap Devarajan wrote: >>>> >>>> >>>> >>>> >>>>> Hi Paul, >>>>> Thanks for your review. I have made changes based on your >>>>> comments >>>> >>>> >>>> >>>> >>>> >>>>> also removed un-wanted dependencies in "depend" file. >>>>> >>>> >>>> Isn't this now just the default set of dependencies, if so then you >>>> could use the default 'depend' by modifying SUNWlibrsync/Makefile to >>>> pick that up and getting rid of your 'depend' file. >>>> >>>> Otherwise it looks okay to me >>>> Paul >>>> >>>> >>>> >>>> >>>> >>>>> Please have a look and let me know if any changes required. >>>>> >>>>> update webrev:- >>>>> http://cr.opensolaris.org/~pd155743/librsync/ >>>>> >>>>> regards, >>>>> Pradhap.D >>>>> >>>>> Paul Cunningham wrote: >>>>> >>>>> >>>>> >>>>>> Pradhap, >>>>>> >>>>>> See below for my quick skip through comments ... >>>>>> >>>>>> Paul >>>>>> >>>>>> Pradhap Devarajan wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> Please review the code for librsync integration into SFW >>>>>>> consolidation >>>>>>> >>>>>>> webrev is located at: >>>>>>> http://cr.opensolaris.org/~pd155743/librsync/ >>>>>>> >>>>>> >>>>>> === Start of Comments ============= >>>>>> >>>>>> 1. usr/src/lib/librsync/Makefile.sfw >>>>>> You might want to use the predefined values for '-prefix=' in >>>>>> Makefile.master, see example in >>>>>> http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html >>>>>> >>>>>> >>>>>> >>>>>> 2. usr/src/pkgdefs/Makefile >>>>>> Put in alphabetical order >>>>>> >>>>>> 3. usr/src/pkgdefs/SUNWlibrsync/depend >>>>>> You might want to move the 'Copyright' statement lines to >>>>>> after the "CDDL HEADER END". >>>>>> Is the sccs ident line correct? >>>>>> Are these dependency pkgs correct? >>>>>> >>>>>> 4. usr/src/pkgdefs/SUNWlibrsync/prototype_i386 >>>>>> Copyright year is wrong >>>>>> >>>>>> === End of Comments =============== >>>>>> >>>>>> >>>> >>>> >> >> >> -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
