On Mon, Apr 28, 2008 at 11:01:37PM +0200, Roland Mainz wrote: > Please add... > -- snip -- > CFLAGS += -xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1 -xstrconst > CFLAGS64 += -xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1 -xstrconst
I think you mean CFLAGS += $(XPG6_MODE) $(XSTRCONST) CFLAGS64 += $(XPG6_MODE) $(XSTRCONST) Though I see that SFW doesn't have ON's XSTRCONST definition in Makefile.master which should be fixed too. I'm a bit confused though as to why C99MODE should need to be set at all since Makefile.master sets it in CFLAGS and C99 is enabled by default. I guess XPG6_MODE is what you're telling him to set anyway so if that's the right thing then he should just use that. This also reminds me that C99LMODE is needed when building lint libraries and I don't see that anywhere in this webrev. In fact I don't see lint libraries at all which is a bug since this wad introduces a library. Adding naked compiler options means more work for the gatekeepers when compiler versions change. -- Keith M Wesolowski "Sir, we're surrounded!" Fishworks "Excellent; we can attack in any direction!"
