Hello Dermot/Mike/Steve,
Thanks for the comments. My responses below for comments
Comments from Dermot McCluskey
---------------------------------------------------------------
> Looks good. Has ARC been done for this yet?
Not done as yet. I filed an RFE yesterday. As per the ARC process, I
believe, once I get the RFE ID, I need to write to arc & sfw list
using the arc 1-pager template.
> If you need Tcl's private headers installed in the proto area
> to build expect, then it's probably better to add the additional
> commands to the "install-sfw" script, rather than adding to
> Makefile.sfw.
>
Will pick it from the sources in the SFW instead of installing them
into proto. As per comment from Mike.
> And don't forget to add the headers to
> $SRC/pkgdefs/etc/exception_list_* so that the build knows these
> files are not being packaged, and so won't throw an error.
>
No longer required since will not be installing.
>
> Also:
> Expect_Build_Configure_RightPaths.diff
> - you should add -M $(SRC)/cmd/mapfile_noexstk to LD_OPTIONS.
> See cmd/*/Makefile.sfw for examples.
> - -with-tcl should point to $(ROOT) proto area, rather than
> "/", so you are building against the version of TCL in the
> SFW build, not the installed version. See
> $SRC/cmd/postgres/postgres-8.2-tcl for example.
> - if you are removing a patch, just delete the line, don't
> comment it out.
>
Accepted.
> Expect_Install_Correct_Paths.diff
> - you shouldn't "mkdir" within the build. Add any extra required
> dirs to $SRC/Targetdirs. (Then do "make setup" in $SRC
> before first building.)
>
Accepted.
> Expect_Migrate_SFWexpct_To_SUNWexpect.diff
> - make sure the prototype entries are sorted - these guys are
> sticklers for that!
Accepted. Will make it alphabetical order. For now will keep
I maintained the earlier order (all file listings are alphabetical
within a dir. Ex: all usr/bin/<files> are in alphabetical order under
usr/bin)
> - VERSION needs to be "VERSION="SFWVERS,REV=0.0.0"
Will change it. But why? How is this used?
> - personally, I like to add the software's version to the DESC
> in pkginfo.tmpl (see SUNWTcl/pkginfo.tmpl for example), but this
> isn't mandatory (yet?)
>
Will keep it as it is for now. "pkginfo -l" will anyway list the
version information.
Mike's Comments
------------------------------------
> I'd say 'what about webrev' but saw you ask about that on -tools :)
>
Also webrev it seems works only with files under an SCM (svn/hg). SFW
currently is not yet under svn/hg.
> I'd also probably just do the sfw bit first and the ccd bit a little
> later, as it is usually behind a few builds (many now because of
> the tcl/tk upgrade) and I'd hate to have a window where there's no
> expect anywhere because it's gone from the ccd but not in sfw since
> the build with it isn't available yet. Unless it hurts having
> one in /opt/sfw too but I wouldn't think it would.
>
No it doesn't. I will not touch CCD.
>
> > 2. Modify tcl's Makefile so that the headers required to build expect
> > are installed
> > File: ${SFW_SRC}/lib/tcl/Makefile.sfw
> > patch: Expect_Install_TclHeaders.diff
> >
> > Query: I have made change to install_h section. This does not get
> > installed as part of "make -f Makefile.sfw install"
> > Should it be made part of "all:" in the Makefile
>
> actually I wonder why you're shipping those at all? We tend to ship
> what the open source thing would really install, and if it doesn't
> install some things when 'make install' runs then we don't either.
That wasn't for shipping. It was a build requirement only.
> Why can't you continue to use, in expect:
> --with-tclinclude=/usr/sfw/src/tcl
> --with-tkinclude=/usr/sfw/src/tk
>
> but change them to point at the source inside the workspace?
> I did some of that when trying to help the ccd cope with the
> tcl/tk upgrade, and it looks like I did something like this:
> --with-tclinclude=$(SRC)/lib/tcl/tcl8.4.14
> --with-tkinclude=$(SRC)/lib/tk/tk8.4.14
>
> well, it's a little different for the ccd since the sources
> aren't in there but I changed the paths above to what it looks
> like they would be.
> > c) Do not install to proto area, refer to tcl & tk's source dir
> > directly within expect's build.
>
> I think 'c' is best for now. I didn't know there was a private
> headers rule in tcl, but if it only installs headers and not
> source then it doesn't fix my main concern about tcl/tk, which is
> things that reach into their source tree and use the headers
> and C files. We probably should just ship their source with the
> packages and be done with it though.
>
Accepted.
I didnt see the latest changes in CCD since I picked the tarball
(quite old). Now I have picked from the snv. Will point it to $(SRC)
>
> >
> > 3. Modify expect's Makefile.sfw so that it uses the right lib/src
> > paths. Remove the earlier existing patch fixline1.patch since it is no
> > longer required.
> > fixline1.patch was used to pick /usr/sfw/bin/tail instead of tail, but
> > tail is avaialble in /usr/bin and the patch is not required.
>
> actually you mean /opt/sfw/bin/tail. But...
>
> so this confuses me - I don't know why this patch is there (tail has
> always been in /usr/bin), so I assume it wanted the one in /opt/sfw/bin
> because that was GNU tail. Which it may still want and should point to
> /usr/gnu/bin/tail instead. I can't find any more information other than
> it was added during the update to 5.39 and created by, I think,
> Paul Cunningham, so perhaps he can add something here :)
>
Yes, I meant /opt/sfw/bin/tail.
B72 doesn't have the sfw paths (/opt/sfw, /usr/sfw,...) There is no
other "tail" command anywhere around.
Will check with an earlier build (B64a) if one existed then and what
purpose it served for expect's build that /usr/bin/tail couldnt do.
> If it does need that then the expect package will need to
> depend on SUNWgnu-coreutils.
>
Not quite. tail command is a build requirement and is not a
requirement for installation & working of expect.
Is there a way to specify build requirements anywhere ?
>
> > 5. Modify Makefile in pkgdefs so that expect package gets created.
> > I have named the package as SUNWexpect.
> > patch: Expect_SFW_PackageCreation_Integration.diff
>
> whoever sponsers this will need to register that package name
> and do the package rti's and such.
>
> SUNWexpect doesn't seem to be taken so that's good.
>
Do I need to do anything to initiate this?
>
> > Testing the packaging:
> > I am not very familiar with SVR4 packaging related aspects. I have
> > made changes based on the existing dir structure and packaging inputs.
> > But doing a make failed to create packages for SFW and CCD. I would
> > need some inputs as to how to build packages in SFW consolidation.
>
> I would need to see the failure. I would think you could almost
> copy the ccd package (SFW*) to usr/src/pkgdefs and call it SUNWexpect,
> and it would work, apart from changing 'sfw' in prototype_com to 'usr'.
Will provide the details once I make the changes based on the comments
and based on the latest CCD from svn and SFW tarball.
> well and maybe the man pages need a 'share' in there.
>
Ok.
When to use /usr/man and when to use /usr/share/man ?
> nightly should build the packages - if you do it by hand
> you need to do 'make all' first to generate some of the files
> then 'make install' should run pkgmk. and of course all the files
> have to be in the proto area for pkgmk to work first.
>
Will verify once other changes are done.
> > 4. I have used sfw-src-20070822.tar.bz2 and ccd-src-20070526.tar.bz2
> > as the sources.
>
> you might want to update since you're a ways behind, though it probably
> doesn't matter too much given you're just adding something. you'll have
> conflicts on cmd/Makefile and pkgdefs/Makefile though.
Will move to the latest.
Steve's Comments
------------------------------------
Already covered within the earlier ones
-Shiv
