Shiv,
Looks good. Has ARC been done for this yet?
A few comments below.
> 2. Modify tcl's Makefile so that the headers required to build expect
> are installed
> File: ${SFW_SRC}/lib/tcl/Makefile.sfw
> patch: Expect_Install_TclHeaders.diff
>
> Query: I have made change to install_h section. This does not get
> installed as part of "make -f Makefile.sfw install"
> Should it be made part of "all:" in the Makefile
If you need Tcl's private headers installed in the proto area
to build expect, then it's probably better to add the additional
commands to the "install-sfw" script, rather than adding to
Makefile.sfw.
And don't forget to add the headers to
$SRC/pkgdefs/etc/exception_list_* so that the build knows these
files are not being packaged, and so won't throw an error.
Also:
Expect_Build_Configure_RightPaths.diff
- you should add -M $(SRC)/cmd/mapfile_noexstk to LD_OPTIONS.
See cmd/*/Makefile.sfw for examples.
- -with-tcl should point to $(ROOT) proto area, rather than
"/", so you are building against the version of TCL in the
SFW build, not the installed version. See
$SRC/cmd/postgres/postgres-8.2-tcl for example.
- if you are removing a patch, just delete the line, don't
comment it out.
Expect_Install_Correct_Paths.diff
- you shouldn't "mkdir" within the build. Add any extra required
dirs to $SRC/Targetdirs. (Then do "make setup" in $SRC
before first building.)
Expect_Migrate_SFWexpct_To_SUNWexpect.diff
- make sure the prototype entries are sorted - these guys are
sticklers for that!
- VERSION needs to be "VERSION="SFWVERS,REV=0.0.0"
- personally, I like to add the software's version to the DESC
in pkginfo.tmpl (see SUNWTcl/pkginfo.tmpl for example), but this
isn't mandatory (yet?)
Dermot
