* David.Comay at Sun.COM <David.Comay at Sun.COM> [2007-04-25 11:03]: > >http://cr.grommit.com/~sch/corewhich/ > > > > you'll find a preliminary webrev of the SFW changes necessary for > > > >PSARC 2007/048 include GNU coreutils 6.7 > >PSARC 2007/049 include GNU which 2.16 > > Sorry for the belated response but here are my comments. > > usr/src/cmd/coreutils/README.sfw > > Options listed doesn't seem to match those in Makefile.sfw? No, these are for bash...
> Also, I thought mike_s said this really only needed to be > present given the source package requirement so perhaps it can > be just removed. Ok, removed. > usr/src/cmd/coreutils/install-sfw > > Line 71 - You could move this in the final else clause (around > line 82) after initializing "man". > > Lines 91-96 - Along with the man page, is there a reason to > install a link to "ginstall" as /usr/gnu/bin/install? Or is it > always called "ginstall" on other systems as well. > > Finally, with the advent of 6539502 I believe the recommended > procedure is for the install-sfw script to be using the > _install() function from install.subr rather than doing > explicit cp/mv/chmod/chown/etc. Corrected. > usr/src/cmd/which/install-sfw > > Line 64 - Nit, but the recursive flag isn't necessary on the > "rm". Fixed. > As with coreutils' install-sfw, is there a reason not to be > using the _install() function from install.subr. Well, no. > usr/src/pkgdefs/Makefile > > Didn't see any changes here but I assume SUNWgnu-coreutils and > SUNWgnu-which are the intended additions. Yes, fixed. > usr/src/pkgdefs/SUNWgnu-coreutils/copyright > > Did you mean to include the CDDL block here? Removed. > Also, the GPL license here seemed truncated. It's the standard copyright block, not the license. > usr/src/pkgdefs/SUNWgnu-coreutils/depend > > As you're using the standard depend file, you don't actually > need to integrate this separate one (and the Makefile then > doesn't need the DATAFILES line.) Deleted. > usr/src/pkgdefs/SUNWgnu-coreutils/pkginfo.tmpl > > Line 33 - Should SFWVERS be included in the VERSION? > > Lines 34-35 - The values of SUNW_PRODNAME and SUNW_PRODVERS are > different than what we usually use. Although I definitely see > the value of including the utility version number in VERSION, > I'm not sure if it makes sense to change these two SUNW_* > values. > > Line 36 - SUNW_PKGTYPE should be "usr". > > Lines 40-42 - Is this the first of the community-supported > pieces of SFW? :-) Set to standard values. > usr/src/pkgdefs/SUNWgnu-coreutils/prototype_com > > Line 56 - /usr/bin/shuf isn't sorted within the list. Fixed. > Line 99 - Can this be sorted into the rest of the /usr/bin > contents (after line 49?) Or was this explicitly done as its > canonical name is "install" (same with the man pages?) The whole contents file is now sorted. This was an artifact of an earlier coreutils version. > Line 133 - I believe Lee is planning on moving > /usr/ccs/bin/tsort soon into /usr/bin as part of PSARC > 2005/420. Which one should actually live in /usr/bin? Bug ID? Target build? (Differing features?) > usr/src/pkgdefs/SUNWgnu-which/copyright > > Same comments as with the coreutils' copyright file. Brought in line as above. > usr/src/pkgdefs/SUNWgnu-which/depend > > Same comments as with the coreutils' depend file. Deleted. > usr/src/pkgdefs/SUNWgnu-which/pkginfo.tmpl > > Same comments as with the coreutils' pkginfo.tmpl file. Set to standard values. > usr/src/pkgdefs/SUNWgnu-which/prototype_com > > Could the list be sorted, please. Done. -- sch at sun.com http://blogs.sun.com/sch/
