> http://cr.opensolaris.org/~sch/corewhich-0517/
usr/src/cmd/Makefile
Could "coreutils" be sorted within the list?
usr/src/cmd/coreutils/install-sfw
Lines 66-70, 78-83 - I think the idea of just installing
ginstall.1 in the standard man location makes the most sense.
usr/src/cmd/which/Makefile.sfw
Line 29 - Unless I missed the loop, I believe this setting of
SHELL is unnecessary (carryover from other Makefile.sfw?)
usr/src/pkgdefs/SUNWgnu-coreutils/pkginfo.tmpl
Sorry, I should have caught this in my original review. I
believe there's a requirement that the various zones-related
pkginfo(4) variables always be set to something. The standard
for something like coreutils would be
SUNW_PKG_ALLZONES="false"
SUNW_PKG_HOLLOW="false"
SUNW_PKG_THISZONE="false"
Line 34 - I've forgotten how SUNW_PRODNAME is used but "SunOS"
is the typical value here (although it appears "webmin" also
defines a customized value.)
usr/src/pkgdefs/SUNWgnu-which/pkginfo.tmpl
Both comments apply here as well.
dsc
